Hi @clintonb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Related: #32431

Base commit: e22b760
Branch: main

Base commit: e22b760
Branch: main

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

It's not clear to me how to fix the lingering issues. I suspect the flow plugin is not being properly loaded for the test_js failures. The test_windows tests may be have the same issue, and/or be a bit too brittle in their error expectations.

My branch meets the needs of my project and I've already spent a few hours digging into these tests to no avail, so I may not invest any more time on this. Feedback, or contributions, are welcome.

Edit: Upgrading to "eslint-plugin-flowtype": "^8.0.3", did not help.

Hi @clintonb, I've been taking a look at this PR to see if I can help out as it's something I'd also like to see merged at some point.

I haven't fully solved the tests failing but I think I've made some progress. You're right that the flow plugin isn't being loaded, on my local branch (https://github.com/skdrew/react-native/tree/chore/update-eslint-config-dependencies) I've added some extra config that does load it - or at least it's supposed to, it's unable to resolve the plugin in the paths but it's a step closer!

I've also tried reference the flowtype plugin directly, but I get Parsing error: Plugin/Preset files are not allowed to export objects, only functions. when doing this. I've also stuck to v7.0.0 of the flowtype plugin as that's the last version that works with eslint v7.

Not sure if this helps at all, I'll keep poking around to see if I can get it sorted but I thought you might be interested to know.

Closing as this was superseeded by #34020
Thanks for sending this over @clintonb though 🙏